https://github.com/matomo-org/matomo/pull/16774 - Mouve

Site d'origine

Skip to content

/ matomo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP requirement in README #16774

Merged
merged 1 commit into from Nov 23, 2020
Merged

Update PHP requirement in README #16774

merged 1 commit into from Nov 23, 2020

Conversation

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 23, 2020

Description:

Guess doesn't make sense to show PHP 5.5 as requirement, even though Matomo 3 will be in LTS for a while...

We also should maybe update this page so the commands at least install php 7.2: https://matomo.org/docs/requirements/#recommended-configuration

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed
@sgiehl
Update PHP requirement in README
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1f2d9da
@sgiehl sgiehl added this to the 4.0.0-RC milestone Nov 23, 2020
@sgiehl sgiehl requested a review from tsteur Nov 23, 2020
@Findus23
Copy link
Member

@Findus23 Findus23 commented Nov 23, 2020

We also should maybe update this page so the commands at least install php 7.2: https://matomo.org/docs/requirements/#recommended-configuration

I guess we can generalize them. At least on Debian e.g. php-fpm is always a metapackage that installs the proper version from the repo.
@tsteur
Copy link
Member

@tsteur tsteur commented Nov 23, 2020

@Findus23 be great to adjust that guide too. Does it work to simply replace 7.0 with eg 8.0 or 7.4?
@tsteur tsteur merged commit b90ff79 into 4.x-dev Nov 23, 2020
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Failed
Details
Travis CI - Branch Build Passed
Details
@tsteur tsteur deleted the phpreq branch Nov 23, 2020
@Findus23
Copy link
Member

@Findus23 Findus23 commented Nov 23, 2020

@tsteur

You can simply replace it with

$ sudo apt-get install php php-curl php-gd php-cli mysql-server php-mysql php-xml php-mbstring

as all of these packages exist in both Debian and Ubuntu and will install the proper version.
@tsteur
Copy link
Member

@tsteur tsteur commented Nov 23, 2020

Thanks @Findus23 updated it and also prepared matomo-org/developer-documentation#397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur

Assignees
No one assigned
Labels
Needs Review not-in-changelog
Projects
None yet
Milestone
4.0.0-RC
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@sgiehl @Findus23 @tsteur

Raccourcis

Commandes

Fermer