https://github.com/matomo-org/matomo/commits?author=tsteur - Mouve

Site d'origine

Permalink
4.x-dev

Commits on May 17, 2021

  1. Make more link work again in marketplace plugin list (#17570)

    fix #17561
    tsteur committed May 17, 2021

Commits on May 13, 2021

  1. Prevent error message in dev mode no date is defined in segment (#17553)

    * Prevent error message in dev mode no date is defined in segment
    
    Have been getting this notification many times every time I fetch a screen and always receive heaps of notifications (when dev mode enabled). This should fix it.
    
    > WARNING: Avoiding segment subquery due to missing start date and/or an end date. Please ensure a start date and/or end date is set when initializing a segment if it's used to build a query. Stacktrace: #0 /piwik/core/Segment.php(266): Piwik\Segment->doesSegmentNeedSubquery('!=', 'eventCategory') #1 /piwik/core/Segment.php(241): Piwik\Segment->getExpressionsWithUnionsResolved(Array) #2 /piwik/core/Segment.php(150): Piwik\Segment->initializeSegment('eventCategory!=...', Array) #3 /piwik/plugins/SegmentEditor/API.php(409): Piwik\Segment->__construct('eventCategory!=...', Array) #4 [internal function]: Piwik\Plugins\SegmentEditor\API->getAll('1') #5 /piwik/core/API/Proxy.php(244): call_user_func_array(Array, Array) #6 /piwik/core/Context.php(28): Piwik\API\Proxy->Piwik\API\{closure}() #7 /piwik/core/API/Proxy.php(335): Piwik\Context::executeWithQueryParameters(Array, Object(Closure)) #8 /piwik/core/API/Request.php(266): Piwik\API\Proxy->call('\\Piwik\\Plugins\\...', 'getAll', Array) #9 /piwik/core/API/Request.php(559): Piwik\API\Request->process() #10 /piwik/plugins/SegmentEditor/SegmentEditor.php(356): Piwik\API\Request::processRequest('SegmentEditor.g...', Array, Array) #11 /piwik/core/Segment.php(624): Piwik\Plugins\SegmentEditor\SegmentEditor::getAllSegmentsForSite(1) #12 /piwik/core/Archive/DataTableFactory.php(588): Piwik\Segment->getStoredSegmentName(1) #13 /piwik/core/Archive/DataTableFactory.php(288): Piwik\Archive\DataTableFactory->setPrettySegmentMetadata(Object(Piwik\DataTable)) #14 /piwik/core/Archive/DataTableFactory.php(259): Piwik\Archive\DataTableFactory->makeDataTableFromSingleBlob(Array, Array) #15 /piwik/core/Archive/DataTableFactory.php(375): Piwik\Archive\DataTableFactory->makeFromBlobRow(Array, Array) #16 /piwik/core/Archive/DataTableFactory.php(347): Piwik\Archive\DataTableFactory->createDataTable(Array, Array) #17 /piwik/core/Archive/DataTableFactory.php(188): Piwik\Archive\DataTableFactory->createDataTableMapFromIndex(Array, Array, Array) #18 /piwik/core/Archive/DataCollection.php(289): Piwik\Archive\DataTableFactory->make(Array, Array) #19 /piwik/core/Archive.php(386): Piwik\Archive\DataCollection->getExpandedDataTable(Array, NULL, NULL, false) #20 /piwik/core/ArchiveProcessor.php(346): Piwik\Archive->getDataTableExpanded('Goals_ItemsSku', NULL, NULL, false) #21 /piwik/core/ArchiveProcessor.php(213): Piwik\ArchiveProcessor->aggregateDataTableRecord('Goals_ItemsSku', NULL, NULL) #22 /piwik/plugins/Goals/Archiver.php(436): Piwik\ArchiveProcessor->aggregateDataTableRecords(Array, NULL, NULL, NULL, NULL, NULL, Array) #23 /piwik/core/Plugin/Archiver.php(103): Piwik\Plugins\Goals\Archiver->aggregateMultipleReports() #24 /piwik/core/ArchiveProcessor/PluginsArchiver.php(168): Piwik\Plugin\Archiver->callAggregateMultipleReports() #25 /piwik/core/ArchiveProcessor/Loader.php(228): Piwik\ArchiveProcessor\PluginsArchiver->callAggregateAllPlugins(2, 0, false) #26 /piwik/core/ArchiveProcessor/Loader.php(163): Piwik\ArchiveProcessor\Loader->prepareAllPluginsArchive(2, 0) #27 /piwik/core/ArchiveProcessor/Loader.php(101): Piwik\ArchiveProcessor\Loader->prepareArchiveImpl('Goals') #28 /piwik/core/Context.php(75): Piwik\ArchiveProcessor\Loader->Piwik\ArchiveProcessor\{closure}() #29 /piwik/core/ArchiveProcessor/Loader.php(105): Piwik\Context::changeIdSite(1, Object(Closure)) #30 /piwik/core/ArchiveProcessor.php(668): Piwik\ArchiveProcessor\Loader->prepareArchive('Goals') #31 /piwik/plugins/Goals/Archiver.php(485): Piwik\ArchiveProcessor->processDependentArchive('Goals', 'visitorType%3D%...') #32 /piwik/core/Plugin/Archiver.php(103): Piwik\Plugins\Goals\Archiver->aggregateMultipleReports() #33 /piwik/core/ArchiveProcessor/PluginsArchiver.php(168): Piwik\Plugin\Archiver->callAggregateMultipleReports() #34 /piwik/core/ArchiveProcessor/Loader.php(228): Piwik\ArchiveProcessor\PluginsArchiver->callAggregateAllPlugins(2, 0, false) #35 /piwik/core/ArchiveProcessor/Loader.php(163): Piwik\ArchiveProcessor\Loader->prepareAllPluginsArchive(2, 0) #36 /piwik/core/ArchiveProcessor/Loader.php(101): Piwik\ArchiveProcessor\Loader->prepareArchiveImpl('VisitsSummary') #37 /piwik/core/Context.php(75): Piwik\ArchiveProcessor\Loader->Piwik\ArchiveProcessor\{closure}() #38 /piwik/core/ArchiveProcessor/Loader.php(105): Piwik\Context::changeIdSite(1, Object(Closure)) #39 /piwik/plugins/CoreAdminHome/API.php(278): Piwik\ArchiveProcessor\Loader->prepareArchive('VisitsSummary') #40 /piwik/core/Archive.php(825): Piwik\Plugins\CoreAdminHome\API->archiveReports(1, Object(Piwik\Period\Week), '2021-05-10', '', 'VisitsSummary', NULL) #41 /piwik/core/Archive.php(624): Piwik\Archive->prepareArchive(Array, Object(Piwik\Site), Object(Piwik\Period\Week)) #42 /piwik/core/Archive.php(571): Piwik\Archive->cacheArchiveIdsAfterLaunching(Array, Array) #43 /piwik/core/Archive.php(497): Piwik\Archive->getArchiveIds(Array) #44 /piwik/core/Archive.php(312): Piwik\Archive->get(Array, 'numeric') #45 /piwik/core/ArchiveProcessor.php(606): Piwik\Archive->getDataTableFromNumeric(Array) #46 /piwik/core/ArchiveProcessor.php(252): Piwik\ArchiveProcessor->getAggregatedNumericMetrics(Array, false) #47 /piwik/core/ArchiveProcessor/PluginsArchiver.php(306): Piwik\ArchiveProcessor->aggregateNumericMetrics(Array) #48 /piwik/core/ArchiveProcessor/PluginsArchiver.php(104): Piwik\ArchiveProcessor\PluginsArchiver->aggregateMultipleVisitsMetrics() #49 /piwik/core/ArchiveProcessor/Loader.php(222): Piwik\ArchiveProcessor\PluginsArchiver->callAggregateCoreMetrics() #50 /piwik/core/ArchiveProcessor/Loader.php(163): Piwik\ArchiveProcessor\Loader->prepareAllPluginsArchive(6, 1) #51 /piwik/core/ArchiveProcessor/Loader.php(101): Piwik\ArchiveProcessor\Loader->prepareArchiveImpl('VisitsSummary') #52 /piwik/core/Context.php(75): Piwik\ArchiveProcessor\Loader->Piwik\ArchiveProcessor\{closure}() #53 /piwik/core/ArchiveProcessor/Loader.php(105): Piwik\Context::changeIdSite(1, Object(Closure)) #54 /piwik/plugins/CoreAdminHome/API.php(278): Piwik\ArchiveProcessor\Loader->prepareArchive('VisitsSummary') #55 /piwik/core/Archive.php(825): Piwik\Plugins\CoreAdminHome\API->archiveReports(1, Object(Piwik\Period\Month), '2021-05-01', '', 'VisitsSummary', NULL) #56 /piwik/core/Archive.php(624): Piwik\Archive->prepareArchive(Array, Object(Piwik\Site), Object(Piwik\Period\Month)) #57 /piwik/core/Archive.php(571): Piwik\Archive->cacheArchiveIdsAfterLaunching(Array, Array) #58 /piwik/core/Archive.php(497): Piwik\Archive->getArchiveIds(Array) #59 /piwik/core/Archive.php(312): Piwik\Archive->get(Array, 'numeric') #60 /piwik/plugins/VisitsSummary/API.php(36): Piwik\Archive->getDataTableFromNumeric(Array) #61 [internal function]: Piwik\Plugins\VisitsSummary\API->get('1', 'month', 'yesterday', false, Array) #62 /piwik/core/API/Proxy.php(244): call_user_func_array(Array, Array) #63 /piwik/core/Context.php(28): Piwik\API\Proxy->Piwik\API\{closure}() #64 /piwik/core/API/Proxy.php(335): Piwik\Context::executeWithQueryParameters(Array, Object(Closure)) #65 /piwik/core/API/Request.php(266): Piwik\API\Proxy->call('\\Piwik\\Plugins\\...', 'get', Array) #66 /piwik/core/API/Request.php(559): Piwik\API\Request->process() #67 /piwik/plugins/CoreHome/Columns/UserId.php(119): Piwik\API\Request::processRequest('VisitsSummary.g...', Array, Array) #68 /piwik/plugins/CoreHome/Columns/UserId.php(104): Piwik\Plugins\CoreHome\Columns\UserId->isUsedInSite('1', 'month', 'yesterday') #69 /piwik/plugins/CoreHome/Columns/UserId.php(89): Piwik\Plugins\CoreHome\Columns\UserId->isUsedInSiteCached('1', 'month', 'yesterday') #70 /piwik/plugins/VisitsSummary/Reports/Get.php(181): Piwik\Plugins\CoreHome\Columns\UserId->isUsedInAtLeastOneSite(Array, 'month', 'yesterday') #71 /piwik/plugins/VisitsSummary/Reports/Get.php(87): Piwik\Plugins\VisitsSummary\Reports\Get->addSparklineColumns(Object(Piwik\Plugins\CoreVisualizations\Visualizations\Sparklines)) #72 /piwik/core/Plugin/ViewDataTable.php(239): Piwik\Plugins\VisitsSummary\Reports\Get->configureView(Object(Piwik\Plugins\CoreVisualizations\Visualizations\Sparklines)) #73 /piwik/core/ViewDataTable/Factory.php(243): Piwik\Plugin\ViewDataTable->__construct('get', 'VisitsSummary.g...', Array) #74 /piwik/core/ViewDataTable/Factory.php(156): Piwik\ViewDataTable\Factory::createViewDataTableInstance('Piwik\\Plugins\\C...', 'VisitsSummary.g...', 'VisitsSummary.g...', Array) #75 /piwik/core/Plugin/Report.php(318): Piwik\ViewDataTable\Factory::build('sparklines', 'VisitsSummary.g...', 'VisitsSummary.g...', 1) #76 /piwik/plugins/CoreHome/Controller.php(58): Piwik\Plugin\Report->render() #77 [internal function]: Piwik\Plugins\CoreHome\Controller->renderReportWidget(Object(Piwik\Plugins\VisitsSummary\Reports\Get)) #78 /piwik/core/FrontController.php(615): call_user_func_array(Array, Array) #79 /piwik/core/FrontController.php(167): Piwik\FrontController->doDispatch('VisitsSummary', 'get', Array) #80 /piwik/core/dispatch.php(32): Piwik\FrontController->dispatch() #81 /piwik/index.php(25): require_once('/Users/thomasst...') #82 {main} (Module: API, Action: get, Method: SegmentEditor.getAll, In CLI mode: false)
    
    * Update API.php
    tsteur committed May 13, 2021

Commits on May 11, 2021

  1. Allow tracker files to be accessed by crawlers (#17542)

    refs #17497
    tsteur committed May 11, 2021

Commits on May 10, 2021

  1. Allow requests to piwik and matomo php again for bots (#17536)

    tsteur committed May 10, 2021

Commits on May 5, 2021

  1. Improve tracker performance when using custom dimensions (one less up…

    …date query per tracking request) (#17521)
    tsteur committed May 5, 2021

Commits on Apr 27, 2021

  1. Link to the Matomo font guide (#17504)

    Now that we have published a detailed guide for this let's link to the guide instead of the partial instructions.
    tsteur committed Apr 27, 2021

Commits on Mar 21, 2021

  1. Ensure second parameter in gmdate is int, not float (#17365)

    see https://forum.matomo.org/t/problem-with-the-two-factor-authentication-setting/41128/12?
    
    > WARNING: /Piwik/core/Cookie.php(155): Warning - gmdate() expects parameter 2 to be int, float given - Matomo 4.1.1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: UsersManager, Action: setIgnoreCookie, In CLI mode: false)
    tsteur committed Mar 21, 2021

Commits on Mar 8, 2021

Commits on Mar 7, 2021

  1. Fix Marketplace falsely thinks a plugin is installed when it is not (#…

    …17278)
    
    * Fix Marketplace falsely thinks a plugin is installed when it is not
    
    * add test
    tsteur committed Mar 7, 2021

Commits on Mar 3, 2021

  1. Prevent possible warning during GeoIP2 update if providers aren't ini…

    …tialised (#17295)
    
    refs https://wordpress.org/support/topic/repeated-php-warnings-on-cron-execution/
    
    It should be better to use the method anyway instead of hard coding the variable.
    tsteur committed Mar 3, 2021

Commits on Feb 18, 2021

  1. Prevent possible exception when accessing an index (#17233)

    see https://wordpress.org/support/topic/undefined-index-piwik_pro_ads_enabled/
    
    I think this should fix the issue. It's technically only a workaround. Not sure why this would show up as an error. I will try to find out more to see if there's a general issue there.
    tsteur committed Feb 18, 2021

Commits on Feb 11, 2021

  1. dont deactivate a core plugin during update (#17213)

    tsteur committed Feb 11, 2021
  2. Revert previous change accidentally committed to 4.x

    tsteur committed Feb 11, 2021
  3. dont deactivate a core plugin during update

    tsteur committed Feb 11, 2021

Commits on Jan 28, 2021

Commits on Jan 26, 2021

  1. Fix possible service worker error in Firefox (#17139)

    * Fix possible service worker error in Firefox
    
    * rebuilt piwik.js
    tsteur committed Jan 26, 2021

Commits on Jan 22, 2021

  1. Update Tag Manager submodule (#17131)

    tsteur committed Jan 22, 2021
  2. Add more information to system check information (#17132)

    * Add more information to system check information
    
    * fix ui test
    tsteur committed Jan 22, 2021

Commits on Jan 21, 2021

  1. Custom tracking timestamp should return an integer to prevent HTTP 50…

    …0 tracking error (#17127)
    
    * Custom tracking timestamp should return an integer to prevent HTTP 500 tracking error
    
    Eg 
    ```
    curl -i -X POST -d '{"requests":["?idsite=1&rec=1&idgoal=21&apiv=1&_id=50d60fcd18ff0c7e&cdt=1610168419&revenue=0&send_image=0","?idsite=1&rec=1&idgoal=21&apiv=1&_id=50d60fcd18ff0c7e&cdt=1610168419&revenue=0&send_image=0"]}' http://your.site/matomo.php
    ```
    
    Can trigger an HTTP 500 error when the request is authenticated (or when using a recent timestamp). That's because when for example A/B tests are configured, then it does a `Date::factory($request->getCurrentTimestamp))` where the timestamp is a `string` and thus the Date class would trigger an exception.
    
    Making sure we return an integer will fix all possible uses.
    
    * fix tests
    
    Co-authored-by: diosmosis <diosmosis@users.noreply.github.com>
    tsteur and diosmosis committed Jan 21, 2021

Commits on Jan 20, 2021

  1. Improve compatibility with jQuery 3 (#17121)

    Which is used in WordPress 5.6+
    
    Also adjusted few premium features with similar issue. refs matomo-org/matomo-for-wordpress#414
    tsteur committed Jan 20, 2021

Commits on Jan 19, 2021

  1. update tagmanager submodule (#17114)

    tsteur committed Jan 19, 2021

Commits on Jan 18, 2021

  1. Disable newVersionAvailable when auto update enabled. (#17105)

    fix #17096
    tsteur committed Jan 18, 2021

Commits on Jan 14, 2021

  1. Update provider plugin (#17093)

    tsteur committed Jan 14, 2021
  2. Add tracking spam prevention plugin as a submodule (#17016)

    * Add tracking spam prevention plugin as a submodule
    
    * update submodule
    
    * fix some ui tests
    
    * fix tests
    
    * fix some tests
    
    * update submodule
    
    * update screenshots
    
    * fix ui tests
    
    * updates expected UI files
    
    Co-authored-by: sgiehl <stefan@matomo.org>
    tsteur and sgiehl committed Jan 14, 2021

Commits on Dec 23, 2020

  1. Force new visit after 10K actions (#17014)

    * Force new visit after 10K actions
    
    * add test
    
    * wording
    
    * fix ui test
    tsteur committed Dec 23, 2020

Commits on Dec 21, 2020

  1. fix potential error in reports purge query (#16988)

    * fix potential error in reports purge query
    
    * add test
    tsteur committed Dec 21, 2020

Commits on Dec 20, 2020

  1. Detect running archivers correctly (#16987)

    fix #16984
    tsteur committed Dec 20, 2020

Commits on Dec 18, 2020

  1. Invalidate archives after deleting a visit to prevent race conditions (

    …#16967)
    
    * Invalidate archives after deleting a visit to prevent race conditions
    
    The deletion of visits can take a while. To prevent any possible race condition we should invalidate archives only after the visits were deleted.
    
    We recently deleted few visits and noticed the reports are still showing the wrong data. Not sure if this was the problem but be still good to change.
    
    * fix test
    
    Co-authored-by: diosmosis <diosmosis@users.noreply.github.com>
    tsteur and diosmosis committed Dec 18, 2020

Commits on Dec 17, 2020

  1. Check for instanceIds when checking for currently running archive pro…

    …cesses (#16974)
    
    fix #16973
    tsteur committed Dec 17, 2020

Commits on Dec 15, 2020

  1. Remember if process ever started (#16950)

    * Remember if process ever started
    
    This can potentially bring a performance improvement as I think sometimes the system would wait for 8 seconds before declaring a process as finished even if it finished after 1s.
    
    What happens is in https://github.com/matomo-org/matomo/blob/4.0.5/core/CliMulti.php#L217-L222 it checks if the process has started by checking if the PID file exists.
    
    However, the `RequestCommand` deletes the PID file as soon as the process finished to signal "it finished". That means when we check in that loop whether the process has started, it would think it hasn't started yet and simply continue until 8s have past and then it would set the process as finished. Vs we can simply remember that once we say once "the process has started" flag then we can always remember this.
    
    I would assume this race condition would happen constantly unless I'm not seeing it right.
    
    * fix test
    tsteur committed Dec 15, 2020
  2. If one process' output is "abnormal", don't declare all other concurr…

    …ently running processes as finished (#16951)
    
    Instead still wait for all the other commands to finish.
    tsteur committed Dec 15, 2020
  3. Avoid filesystem checks when process was set as finished (#16954)

    Because in CliMulti we might check in a loop for every process constantly if they are finished. It won't help all that much but better to not check every time the file system when it is not needed.
    
    There be many other things we could improve there. Will add some comments but probably best not to do them (or we'll see if it's needed later)
    tsteur committed Dec 15, 2020
  4. Only mark process as finished after fully sending the output (#16952)

    Otherwise there could be a race condition in cli multi where it thinks the process is finished, but the output hasn't been sent and written yet. Thus ending up with an "empty response" error under circumstances or only reading a partial output. This should only affect Matomo for WordPress though
    tsteur committed Dec 15, 2020
Older

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/commits?author=tsteur.

Récupération de l'URL https://github.com/matomo-org/matomo/commits?author=tsteur...

Raccourcis

Commandes

Fermer