https://github.com/matomo-org/matomo/issues/12420 - Mouve

Site d'origine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish renaming Piwik to Matomo everywhere #12420

Open
mattab opened this issue Jan 10, 2018 · 8 comments
Open

Finish renaming Piwik to Matomo everywhere #12420

mattab opened this issue Jan 10, 2018 · 8 comments
Assignees
Milestone

Comments

@mattab
Copy link
Member

@mattab mattab commented Jan 10, 2018

In January 2018 we announced that Piwik is now Matomo 🎉

As part of the renaming efforts we're updating all our websites, tools, core app, plugins, ie. everything!

Renaming checklist left to do:

  • make the build files matomo.zip and matomo.tar.gz, as well as the directory inside the builds should be called matomo
  • plugin CustomPiwikJs to be renamed eg. CustomJsTracker --> see #13604
  • plugin AnonymousPiwikUsageMeasurement to be renamed (out of scope for Matomo 4)
  • HTTP Tracking API endpoints: piwik.js and piwik.php
  • JavaScript tracking sdk with objects like Piwik and window.Piwik and methods like getPiwikUrl
  • Plugin developers, core platform uses namespace Piwik + some objects called "Piwik"
  • Rename events eg Piwik.getJavascriptCode
  • cookie names eg piwik_auth
  • URL parameter like piwik_campaign to also support matomo_campaign --> done with #15957
  • HTTP API methods eg. ExampleAPI.getPiwikVersion -> 3.3.0
  • DB prefix like piwik_ -> 3.3.0
  • Remove --piwik-domain console parameter (see #13192) - Will be done with #15503
  • After a successful auto-update, the screen shows Piwik is now Matomo and a big image. Be good to remove both. --> Will be done with #15504
  • Marketplace URL parameters like "piwik_version"
  • plugin.json parameters like require "piwik"
  • CSS classes etc (out of scope for Matomo 4)
  • angular directives like piwik-foobar (out of scope for Matomo 4)
  • Remove Piwik font (already "renamed" to Matomo in #12489)
  • Tracker proxy: Add matomo.php with keeping BC + Update [faq])https://matomo.org/faq/how-to/faq_132/) matomo-org/tracker-proxy#55
  • update all doc blocks with new name / url --> #15857
  • ... and more

In the case of Matomo core platform we want to keep things backward compatible for users including HTTP APIs users or users of the JavaScript SDKs.

Assigning to Matomo 4.0.0 but hopefully we can tackle a few of the list, and make progress on the others, during Matomo 3.x 🚀

@linusg
Copy link

@linusg linusg commented Jul 15, 2018

Hey there,

not sure if there's a separate repo for the website (matomo.org, didn't found one), but I think it will fit in here.

On the main page, there's this animation:

image

On the truck it say's Piwik, so that should be changed at one point in the future. :-)

Cheers!

@tsteur
Copy link
Member

@tsteur tsteur commented Apr 13, 2020

As part of this issue it be important to look at which ones are easy and quick to do. The rest we'll do as part of Matomo 5.

@tsteur
Copy link
Member

@tsteur tsteur commented Jun 5, 2020

for tracker created matomo-org/tracker-proxy#61

@tsteur
Copy link
Member

@tsteur tsteur commented Jun 12, 2020

I reckon we can move the rest to Matomo 5? The only question would be wether we want to release another Matomo 2 and Matomo 3 update with the legacy auto loader: https://github.com/matomo-org/matomo/blob/4.x-dev/LegacyAutoloader.php#L17

This way should we ever change the namespace then it would cause less upgrade issues.

@sgiehl @mattab I reckon it could make sense to add the autoloader and release new version also for Matomo 2.* users

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 14, 2020

@tsteur Yes. Guess it makes sense to release new versions for 2.x and 3.x with the autoloader, so we have smoother updates later...

@tsteur
Copy link
Member

@tsteur tsteur commented Jun 15, 2020

@sgiehl created this for 3.x-dev: https://github.com/matomo-org/matomo/compare/3.x-dev...legacyautoloader?expand=1 would create the same for 2.x-dev... do you reckon this would help?

Generally thinking the autloader needs to work both ways Piwik -> Matomo and Matomo -> Piwik

  • Core updater runs with 3.x, all files from Matomo are being updated
  • Now it tries to request \Piwik\Http class in https://github.com/matomo-org/matomo/blob/3.13.6/plugins/CoreUpdater/Updater.php#L131
  • Because the file core/Http was replaced this file will contain \Matomo\Http... and no longer \Piwik\Http...
  • The error would not be solved by this legacy autoloader unless we add alias as needed both ways (which I now did in the updated code base)

On another note noticed there is also interface_exists. Hoping we won't run into any issues around interfaces but luckily we don't use them much :)

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 15, 2020

Aren't we running most of the update process on the new code base? 🤔

But guess it makes sense to have the autoloader in both ways, to be sure there can't be any renamed class missing...

tsteur added a commit that referenced this issue Jun 15, 2020
refs #12420
@tsteur
Copy link
Member

@tsteur tsteur commented Jun 18, 2020

FYI we basically need to release a Matomo 2 release and then we can move this issue into Matomo 5 milestone.

@tsteur tsteur modified the milestones: 4.0.0, 5.0.0 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/issues/12420.

Récupération de l'URL https://github.com/matomo-org/matomo/issues/12420...

Raccourcis

Commandes

Fermer