https://github.com/matomo-org/matomo/pull/17432 - Mouve

Site d'origine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run JavaScript tests also with node/puppeteer #17432

Merged
merged 4 commits into from Apr 11, 2021
Merged

Run JavaScript tests also with node/puppeteer #17432

merged 4 commits into from Apr 11, 2021

Conversation

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 7, 2021

Description:

The PR also includes some changes to JS tests, so they don't fail in a browser that supports sendBeacon

requires matomo-org/travis-scripts#68

fixes #17424

Before merging this on, the travis-scripts PR needs to be merged and the submodule reference in this PR needs an update.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed
sgiehl added 2 commits Apr 6, 2021
@tsteur
Copy link
Member

@tsteur tsteur commented Apr 7, 2021

@sgiehl I'm almost thinking maybe we don't want this just yet as it may be more valuable to know that the tracking works in older browsers and then most likely it also works in newer browsers. Vs if we run it in a newer browser it's harder to ensure it works in an older browser. We may not want this change just yet maybe.

@Findus23
Copy link
Member

@Findus23 Findus23 commented Apr 7, 2021

I think the Javascript test is one of the fastest (taking just a few minutes). So maybe it might be possible to run both.

@diosmosis
Copy link
Member

@diosmosis diosmosis commented Apr 7, 2021

Just saw this after looking at the travis-scripts PR. I can revert the merge I did if needed.

@sgiehl
Copy link
Member Author

@sgiehl sgiehl commented Apr 8, 2021

running both sounds fair enough. should be simple to do that. will update this PR

@sgiehl sgiehl force-pushed the jstestsonnode branch 2 times, most recently from 360c202 to fe99f5a Apr 8, 2021
@sgiehl sgiehl force-pushed the jstestsonnode branch from fe99f5a to 2d765cf Apr 8, 2021
@sgiehl sgiehl changed the title Run JavaScript tests with node/puppeteer instead of phantomjs Run JavaScript tests also with node/puppeteer Apr 8, 2021
@sgiehl
Copy link
Member Author

@sgiehl sgiehl commented Apr 8, 2021

Updated the PR so the travis job should first run the tests on node and afterwards on phantomjs

@diosmosis diosmosis merged commit 4850fae into 4.x-dev Apr 11, 2021
1 of 3 checks passed
1 of 3 checks passed
@github-actions
PHPCS
Details
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@diosmosis diosmosis deleted the jstestsonnode branch Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/pull/17432.

Récupération de l'URL https://github.com/matomo-org/matomo/pull/17432...

Raccourcis

Commandes

Fermer