https://github.com/matomo-org/matomo/pull/17437 - Mouve

Site d'origine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow setting partial archives to DONE_INVALIDATED #17437

Merged
merged 1 commit into from Apr 11, 2021

Conversation

@diosmosis
Copy link
Member

@diosmosis diosmosis commented Apr 9, 2021

Description:

Since DONE_INVALIDATED archives are treated the same as DONE_OK ones, we don't want partial archives to be set this way, as it changes the content.

I thought this was already in the code, but apparently it's not.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed
@diosmosis diosmosis added this to the 4.3.0 milestone Apr 9, 2021
@diosmosis
Copy link
Member Author

@diosmosis diosmosis commented Apr 9, 2021

Refs #17428

@diosmosis
Copy link
Member Author

@diosmosis diosmosis commented Apr 9, 2021

FYI @tsteur

@sgiehl
sgiehl approved these changes Apr 9, 2021
Copy link
Member

@sgiehl sgiehl left a comment

Code looks good. Even though I might not be able to overlook to full impact of this change

@diosmosis
Copy link
Member Author

@diosmosis diosmosis commented Apr 11, 2021

FYI @tsteur, merging this one

@diosmosis diosmosis merged commit 3b1e602 into 4.x-dev Apr 11, 2021
1 of 3 checks passed
1 of 3 checks passed
@github-actions
PHPCS
Details
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@diosmosis diosmosis deleted the partial-archive-no-inval branch Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/pull/17437.

Récupération de l'URL https://github.com/matomo-org/matomo/pull/17437...

Raccourcis

Commandes

Fermer