Fixes for specific case when partial archives have to initiate archiving for child archives #17439
Includes new test case and changes to make it pass. See inline comments for individual changes/fixes.
…hecks for partial archives, fix a couple issues that arise when archiving a multi-period partial archive that has to initiate archiving for a child archive and reuse archives for a child archive.
tsteur left a comment
haven't tested anything but left few comments just to check. Looked through the code and wasn't sure if it could maybe result in some wrong archiving like when we mark something as not partial but we actually only want to archive a plugin.
I don't think it's technically necessary to set it, but it makes sense to be thorough.
I thought about unsetting it in that method, but we never re-use Parameters objects anywhere else (and shouldn't in normal uses), so it seemed like it could cause strange side effects.
In that specific line of code, no, because that's the start of the prepareArchive() method. In fact in that line of code we don't need to call the method there. I'll remove that.
Don't need to since we archive VisitsSummary before other plugins. We could do it, though, just in case something changes in the future.