https://github.com/matomo-org/matomo/pull/17440 - Mouve

Site d'origine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up integration tests by not using DbHelper::getTablesInstalled() #17440

Merged
merged 2 commits into from Apr 11, 2021

Conversation

@diosmosis
Copy link
Member

@diosmosis diosmosis commented Apr 9, 2021

Description:

Now in DbHelper::getTablesInstalled() we post an event and force load all activated plugins: https://github.com/matomo-org/matomo/blob/4.x-dev/core/Db/Schema/Mysql.php#L453-L458

This is quite a bit more work, it seems. Locally it slows each individual integration test case by about 14s. Removing it speeds the LoaderTest, for example, from 10mins to finish to 1min.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed
@diosmosis
Copy link
Member Author

@diosmosis diosmosis commented Apr 9, 2021

@sgiehl updated.

@sgiehl
sgiehl approved these changes Apr 11, 2021
@sgiehl sgiehl merged commit d76d7e2 into 4.x-dev Apr 11, 2021
1 of 3 checks passed
1 of 3 checks passed
@github-actions
PHPCS
Details
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@sgiehl sgiehl deleted the integration-test-perf branch Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/pull/17440.

Récupération de l'URL https://github.com/matomo-org/matomo/pull/17440...

Raccourcis

Commandes

Fermer