https://github.com/matomo-org/matomo/pull/17445 - Mouve

Site d'origine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct no access message is shown #17445

Merged
merged 3 commits into from Apr 14, 2021
Merged

Ensure correct no access message is shown #17445

merged 3 commits into from Apr 14, 2021

Conversation

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 12, 2021

Description:

While testing I recognized, that when an access exception is thrown Matomo currently always shows a "session expired" error, even though the user might still be logged in, but simply does not have access for the current site.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed
@diosmosis
Copy link
Member

@diosmosis diosmosis commented Apr 12, 2021

Tested locally, works for me. Is it possible to get this tested?

@diosmosis diosmosis added this to the 4.3.0 milestone Apr 12, 2021
@sgiehl sgiehl force-pushed the autherror branch from e1ab239 to 9736e15 Apr 13, 2021
@sgiehl sgiehl force-pushed the autherror branch from 9736e15 to fa0c1f3 Apr 13, 2021
@sgiehl
Copy link
Member Author

@sgiehl sgiehl commented Apr 13, 2021

@diosmosis added some UI tests for it

Copy link
Member

@diosmosis diosmosis left a comment

I was thinking we could get away w/ an integration test, but UI works too.

@sgiehl sgiehl merged commit ea561b5 into 4.x-dev Apr 14, 2021
2 of 3 checks passed
2 of 3 checks passed
@github-actions
PHPCS
Details
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@sgiehl sgiehl deleted the autherror branch Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/pull/17445.

Récupération de l'URL https://github.com/matomo-org/matomo/pull/17445...

Raccourcis

Commandes

Fermer