https://github.com/matomo-org/matomo/pull/17453 - Mouve

Site d'origine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix random failure + update two screenshots #17453

Merged
merged 2 commits into from Apr 13, 2021

Conversation

@diosmosis
Copy link
Member

@diosmosis diosmosis commented Apr 13, 2021

Description:

Exclude more columns from failing BlobReportLimitingTest and update two screenshots

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed
@diosmosis diosmosis merged commit c900fab into 4.x-dev Apr 13, 2021
1 of 3 checks passed
1 of 3 checks passed
@github-actions
PHPCS
Details
@travis-ci
Travis CI - Branch Build Errored
Details
@travis-ci
Travis CI - Pull Request Build Errored
Details
@diosmosis diosmosis deleted the blobreportlimiting-random-failure branch Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/pull/17453.

Récupération de l'URL https://github.com/matomo-org/matomo/pull/17453...

Raccourcis

Commandes

Fermer