https://github.com/matomo-org/matomo/pull/17460 - Mouve

Site d'origine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some assertions for segment rearchive so there is test coverage #17460

Merged
merged 1 commit into from Apr 15, 2021

Conversation

@diosmosis
Copy link
Member

@diosmosis diosmosis commented Apr 15, 2021

Description:

Noticed there weren't any explicit tests for this so I added a couple.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed
Copy link
Contributor

@flamisz flamisz left a comment

LGTM and tests are passing

@sgiehl sgiehl merged commit 6e3f165 into 4.x-dev Apr 15, 2021
3 checks passed
3 checks passed
@github-actions
PHPCS
Details
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@sgiehl sgiehl deleted the segment-rearchive-quick-test branch Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/pull/17460.

Récupération de l'URL https://github.com/matomo-org/matomo/pull/17460...

Raccourcis

Commandes

Fermer