https://github.com/matomo-org/matomo/pull/17464 - Mouve

Site d'origine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating reports in TSV format #17464

Merged
merged 2 commits into from Apr 16, 2021
Merged

Allow generating reports in TSV format #17464

merged 2 commits into from Apr 16, 2021

Conversation

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 15, 2021

Description:

This PR will make it possible to send scheduled reports in TSV format.

Note: Did those changes in a couple of minutes only. Will try to complete the PR when I have some time in between maybe.

fixes #17463

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed
@sgiehl sgiehl self-assigned this Apr 15, 2021
@sgiehl sgiehl marked this pull request as ready for review Apr 15, 2021
@sgiehl sgiehl removed their assignment Apr 15, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Apr 16, 2021
@diosmosis
Copy link
Member

@diosmosis diosmosis commented Apr 16, 2021

Works for me and tests pass, merging

@diosmosis diosmosis merged commit affd373 into 4.x-dev Apr 16, 2021
1 of 3 checks passed
1 of 3 checks passed
@github-actions
PHPCS
Details
@travis-ci
Travis CI - Branch Build Failed
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
@diosmosis diosmosis deleted the tsvreports branch Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/pull/17464.

Récupération de l'URL https://github.com/matomo-org/matomo/pull/17464...

Raccourcis

Commandes

Fermer