https://github.com/matomo-org/matomo/pull/17466 - Mouve

Site d'origine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow goals being triggered when a visitor visits a certain number of pages #17466

Open
wants to merge 4 commits into
base: 4.x-dev
Choose a base branch
from

Conversation

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 16, 2021

Description:

fixes #2029

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed
core/Tracker/GoalManager.php Outdated Show resolved Hide resolved
@sgiehl sgiehl marked this pull request as ready for review Apr 16, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Apr 16, 2021
@sgiehl sgiehl force-pushed the pageviewgoal branch 2 times, most recently from 2a1533d to ef6cb73 Apr 16, 2021
@sgiehl sgiehl modified the milestones: 4.3.0, 5.0.0 May 3, 2021
sgiehl added 3 commits Apr 16, 2021
… pages
@sgiehl sgiehl force-pushed the pageviewgoal branch 2 times, most recently from b7eeb2e to f3c771c May 6, 2021
@sgiehl sgiehl force-pushed the pageviewgoal branch from f3c771c to 713135f May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants

level de log mis à 1

Récupération du document https://github.com/matomo-org/matomo/pull/17466.

Récupération de l'URL https://github.com/matomo-org/matomo/pull/17466...

Raccourcis

Commandes

Fermer